Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pandas api isin #30

Merged
merged 15 commits into from
Jan 22, 2024
Merged

Feature/pandas api isin #30

merged 15 commits into from
Jan 22, 2024

Conversation

marcosvm13
Copy link

@marcosvm13 marcosvm13 commented Jan 17, 2024 •
edited
Loading

Feature sem

What does this change introduce?

  • Provides an implemementation for the isin method

It follow the pandas definition.

General

  • Has an example been added to demo the new feature?
  • Have existing examples been updated or tested?
  • Have you added any new Environment Variables/Configuration Options? If yes please tick the boxes below as applicable
    • Addition to reimporter logic within src/pykx/pykx.q and src/pykx/reimporter.py
    • Have updated the src/pykx/util.py logic which is used for environment variable
  • If there have been any dependency updates have they been reflected in all files?
    • pyproject.toml
    • docs/getting-started/installing.md
    • conda-recipe/meta.yaml
    • README.md
  • If any examples have been updated has it's associated .zip been updated

Code

  • Has all temporary code used during development been removed?
  • Has all commented out (unused) code been removed?
  • Where reasonable have you ensured there is no duplication of existing code?
  • If applicable for your use-case have you ensured that the code is performant?

Testing

  • Have unit tests been created or existing ones updated to test this new functionality?

Documentation

  • Has documentation been added for all public code?
  • Has a release note been included for the new feature?
  • Has any documentation which would benefit from this feature been updated to use the most up to date functionality?
  • If a new class has been added has a documentation stub .md file associated with it been created?
  • If any documentation page has been created has it been added to mkdocs.yml
  • Have you checked your changes with a spell checker? (US English)

@marcosvm13 marcosvm13 added the work in progress Working on it label Jan 17, 2024
@marcosvm13 marcosvm13 added this to the Pandas API 2nd Block milestone Jan 17, 2024
@marcosvm13 marcosvm13 self-assigned this Jan 17, 2024
chraberturas
chraberturas reviewed Jan 17, 2024
View reviewed changes
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
@cperezln cperezln marked this pull request as draft January 18, 2024 07:38
@github-actions github-actions bot added the tests label Jan 22, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 22, 2024
@marcosvm13 marcosvm13 added Ready to review and removed work in progress Working on it labels Jan 22, 2024
@marcosvm13 marcosvm13 marked this pull request as ready for review January 22, 2024 14:21
@marcosvm13 marcosvm13 linked an issue Jan 22, 2024 that may be closed by this pull request
Feature: Implement isin from Pandas API #18
Open
tortolavivo23
tortolavivo23 suggested changes Jan 22, 2024
View reviewed changes
Copy link

@tortolavivo23 tortolavivo23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I indicate all the changes suggested by pflake8

src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
tests/test_pandas_api.py Show resolved Hide resolved
tests/test_pandas_api.py Outdated Show resolved Hide resolved
nipsn
nipsn requested changes Jan 22, 2024
View reviewed changes
Copy link

@nipsn nipsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation of the lines I pointed to if possible.

src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
@marcosvm13 marcosvm13 requested a review from nipsn January 22, 2024 16:48
@marcosvm13 marcosvm13 merged commit dc61926 into feature/pandas-api-2nd-block Jan 22, 2024
1 check passed
nipsn added a commit that referenced this pull request Feb 16, 2024
@nipsn @marcosvm13
Feature/pandas api isin (#30)
f0e67c1 
code, test and documentation of isin
---------

Co-authored-by: marcosvm13 <marcos.vazquez@hablapps.com>
Co-authored-by: cperezln <cristian.perez@hablapps.com>
nipsn added a commit that referenced this pull request Mar 11, 2024
@nipsn @marcosvm13
Feature/pandas api isin (#30)
f90f42b 
code, test and documentation of isin
---------

Co-authored-by: marcosvm13 <marcos.vazquez@hablapps.com>
Co-authored-by: cperezln <cristian.perez@hablapps.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipsn nipsn nipsn approved these changes

@tortolavivo23 tortolavivo23 tortolavivo23 approved these changes

@cperezln cperezln cperezln approved these changes

@chraberturas chraberturas chraberturas approved these changes

@MiguelGomezC MiguelGomezC Awaiting requested review from MiguelGomezC

Assignees

@marcosvm13 marcosvm13

Labels
documentation Improvements or additions to documentation python Ready to review tests
Projects
None yet
Milestone
Pandas API 2nd Block
Development

Successfully merging this pull request may close these issues.

Feature: Implement isin from Pandas API
5 participants
@marcosvm13 @nipsn @tortolavivo23 @cperezln @chraberturas