This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
Fixes fingerprints.json: too many open files Error #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the tool with the following arguments the script would error due to a condition where too many open files occurred.
After review, it appears that each goroutine within subjack.dns() would read the fingerprints file. Refactored the code to read the fingerprints.json file once and then pass the []Fingerprints struct into the goroutines.
This appears to be working well for me and likely has some performance gains as well.