Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading username and password from environment #11

Merged
merged 1 commit into from
May 12, 2019

Conversation

acez
Copy link
Contributor

@acez acez commented Dec 30, 2018

Hello,

thanks for your great tool. I want to use it in a docker based environment and need to supply username and password via the environment.
This allows to load username and password from environment variables specified in the config. It is implemented in the same non-breaking way as bcrypt support. I added an example in the readme.

Best,
Christian

@hacdias hacdias merged commit 4199ffc into hacdias:master May 12, 2019
@hacdias
Copy link
Owner

hacdias commented May 12, 2019

Thanks and sorry for taking so long merging this :(

@kuro7766
Copy link

kuro7766 commented Aug 6, 2021

I'm new to this repo and I think it's a bad design. I have met the same problem like #83 because of this merge.
Here is what I have done:

  • Copy yml file in README.md to ./
  • run binary file with no params

but throws an error

the environment variable is empty

And this solves my problem. Just remove those {env} statements.

Add trouble for beginners to understand and config. Or this should not be the default behaviour.

@acez
Copy link
Contributor Author

acez commented Aug 17, 2021

@kuro7766 This was just an example to show what is possible and how the feature is working.
Removing {env} from the string just disables the feature to get the data from the environment - but also enables login with username "ENV_USERNAME" and password "ENV_PASSWORD".
You can just remove both lines and you'll be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants