Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Python package to meteofrance_api #70

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

oncleben31
Copy link
Member

Old Python package name (meteofrance) was for retro compatibility with another Python package managing weather forecast from Météo-France.
We prefer to have same name for package and project.

Old Python package name (meteofrance) was for retro compatibility with other
Python package managing weather forecast from Météo-France.
We prefere to have same package and project name.
@oncleben31 oncleben31 added breaking Breaking Changes refactoring Refactoring labels Oct 21, 2020
@oncleben31 oncleben31 linked an issue Oct 21, 2020 that may be closed by this pull request
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Looks good to me.

@@ -9,9 +9,6 @@ homepage = "https://github.com/hacf-fr/meteofrance-api"
repository = "https://github.com/hacf-fr/meteofrance-api"
documentation = "https://meteofrance-api.readthedocs.io"
keywords = ["weather", "weather-api", "meteo"]
packages = [
{ include = "meteofrance", from = "src" },
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need of this ?

@Quentame
Copy link
Member

Should we release and update HA after that ?
Or maybe you have something else to work on before ?

@oncleben31
Copy link
Member Author

Yes and I propose to bump package version to 1.0.0

@oncleben31 oncleben31 merged commit 7db500a into master Oct 21, 2020
@oncleben31 oncleben31 deleted the module-rename branch October 21, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Python module name with meteofrance_api
2 participants