Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save to localstorage #1

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Save to localstorage #1

merged 4 commits into from
Oct 8, 2019

Conversation

victorperin
Copy link
Member

Each interaction with the form fields now save it to the localstorage. So, as an user, if something went wrong on my browser I can just open the page again and all fields will still be there.

Example

I've also added some basic tests on localstorage wrapper file.

@victorperin victorperin added the enhancement New feature or request label Oct 7, 2019
@degrecci
Copy link
Member

degrecci commented Oct 7, 2019

Nice feature 🎉 🎉 🎉
I think it would also be interesting to have a button to clear all information from localstorage.

@victorperin
Copy link
Member Author

I think this button is an good addition, but I would make it in another pull request. (I will create an issue for that).

Copy link
Member

@degrecci degrecci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ;)

@victorperin victorperin merged commit d132055 into master Oct 8, 2019
@victorperin victorperin deleted the feat/save-to-localstorage branch October 8, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants