Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Modal #38

Closed
wants to merge 4 commits into from
Closed

Finish Modal #38

wants to merge 4 commits into from

Conversation

ryanhu021
Copy link
Contributor

@ryanhu021 ryanhu021 commented Jan 31, 2022

HomeModal component:

  • Uses MUI Modal component
  • Accepts any React component as children
  • Opened by changing a state boolean
  • Props:
    • children: child components
    • open: boolean that opens modal when set to true
    • handleClose: state function to set open to false when modal is closed
  • Width adjusts based on device type

Demo images:

  • Homepage buttons

image

  • Basic text modal

image

  • Modal with calendar component

image

  • Mobile

image

Other notes:

  • Installed @emotion/react and @emotion/styled due to errors when importing MUI components

@ryanhu021 ryanhu021 linked an issue Jan 31, 2022 that may be closed by this pull request
2 tasks
@vwinstea
Copy link
Contributor

vwinstea commented Feb 1, 2022

This is great! However, I'm personally struggling to figure out the best way move between pages. For example, a lot of the mock-ups show us navigating from one modal to another. However, with React Router, I'm not sure if we'll be able to change what's in the modal without exiting out of it. Right now, your demos do a good job showing entering/exiting modals, but I'm not sure how to change what's in the modal without getting out of it. Do you have any ideas?

@vwinstea
Copy link
Contributor

vwinstea commented Feb 7, 2022

Thanks for getting this done! I'm going to close this branch instead of merging it since it was more of a research task, but everything look good!

FYI - If you want to use this branch for the next part of your task, make sure to run git pull origin main on this branch so you can get this branch up to date before working on it.

@vwinstea vwinstea closed this Feb 7, 2022
@vwinstea vwinstea mentioned this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Modal
2 participants