Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

Add initial workshop project click implementation #388

Merged
merged 12 commits into from
Dec 30, 2018
Merged

Add initial workshop project click implementation #388

merged 12 commits into from
Dec 30, 2018

Conversation

maxwofford
Copy link
Member

No description provided.

@lachlanjc
Copy link
Member

Thank you!! 💖

zachlatta
zachlatta previously requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@zachlatta zachlatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for the most part. Left a few comments that need to be addressed before merge.

app/controllers/v1/workshop_project_clicks_controller.rb Show resolved Hide resolved
app/models/workshop_project_click.rb Show resolved Hide resolved
app/models/workshop_project_click.rb Outdated Show resolved Hide resolved
spec/factories/workshop_project_clicks.rb Show resolved Hide resolved
spec/models/workshop_project_click_spec.rb Outdated Show resolved Hide resolved
spec/models/workshop_project_click_spec.rb Outdated Show resolved Hide resolved
zachlatta
zachlatta reviewed Dec 5, 2018
View reviewed changes
Copy link
Member

@zachlatta zachlatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just one last comment I forgot in earlier review.

app/serializers/workshop_project_click_serializer.rb Outdated Show resolved Hide resolved
@zachlatta
Copy link
Member

Oh, and on the above comment, do you intend to render the click count anywhere?

@maxwofford
Copy link
Member Author

@zachlatta Just addressed each of the comments with the new changes

@maxwofford
Copy link
Member Author

re: click count

Will add it once I talk to @lachlanjc & @polytroper about where they want the info displayed

@maxwofford
Copy link
Member Author

@lachlanjc: I figure it makes sense to add 'total click count' as a field on workshop projects

@zachlatta
Copy link
Member

Hey, so I still don't see all of my comments addressed. Can you let me know once you've addressed everything? I've dismissed the things I see addressed.

@maxwofford
Copy link
Member Author

@zachlatta sure you're looking at latest? the open comments were all outdated

@lachlanjc
Copy link
Member

@zachlatta Can you review this please?

@maxwofford
Copy link
Member Author

@zachlatta just sending a friendly ping on this

@maxwofford maxwofford dismissed zachlatta’s stale review December 30, 2018 11:16

All comments addressed

@maxwofford maxwofford merged commit cf3efed into master Dec 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zachlatta zachlatta zachlatta left review comments

Assignees

@zachlatta zachlatta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxwofford @lachlanjc @zachlatta