Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve slope movement #256

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Improve slope movement #256

merged 1 commit into from
Oct 21, 2023

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Oct 21, 2023

  • Use same boxcast as ground check
  • Find slope normal
  • Use slope normal if angle is low enough

Closes #255

Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 👍

I suggest we set the slopeAngleTreshold to 50 instead maybe? I think 60 is a bitt too much (see gif)

Also this reminds me that we could slap on some IK for the player legs, but that'll have to be a discussion we take another time (and in another issue)

climber

- Use same boxcast as ground check
- Find normal
- Use slope normal if angle is low enough
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🎉

@toberge toberge merged commit 9342d87 into main Oct 21, 2023
@toberge toberge deleted the feature/slope-movement branch October 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Slope movement
2 participants