-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Special Permissions API v2 #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Whoops, didn't realize this was still a draft 😅 But yeah it looks good other than the failing build. |
Yeah, I need to fix the JSON unmarshaller 😅 |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 90.16% 90.57% +0.40%
==========================================
Files 33 33
Lines 2278 2503 +225
==========================================
+ Hits 2054 2267 +213
- Misses 160 169 +9
- Partials 64 67 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves #110
Implements
Set Special Permissions
v2 API operation.