Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Special Permissions API v2 #116

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Conversation

seanjparker
Copy link
Contributor

Resolves #110

Implements Set Special Permissions v2 API operation.

@seanjparker seanjparker added the auth-v2 Issues relating to the Auth V2 design label Oct 8, 2020
@seanjparker seanjparker self-assigned this Oct 8, 2020
@seanjparker seanjparker marked this pull request as draft October 8, 2020 20:22
Copy link
Collaborator

@kzalys kzalys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kzalys kzalys self-requested a review October 8, 2020 21:31
@kzalys
Copy link
Collaborator

kzalys commented Oct 8, 2020

Whoops, didn't realize this was still a draft 😅 But yeah it looks good other than the failing build.

@seanjparker
Copy link
Contributor Author

Whoops, didn't realize this was still a draft 😅 But yeah it looks good other than the failing build.

Yeah, I need to fix the JSON unmarshaller 😅

@seanjparker seanjparker marked this pull request as ready for review October 9, 2020 16:36
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #116 into master will increase coverage by 0.40%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   90.16%   90.57%   +0.40%     
==========================================
  Files          33       33              
  Lines        2278     2503     +225     
==========================================
+ Hits         2054     2267     +213     
- Misses        160      169       +9     
- Partials       64       67       +3     
Impacted Files Coverage Δ
...thorization/v2/common/uniformResourceIdentifier.go 97.01% <82.60%> (-2.99%) ⬇️
routers/api/v2/router.go 77.27% <100.00%> (+8.85%) ⬆️
routers/api/v2/users.go 94.81% <100.00%> (-0.45%) ⬇️
routers/router.go 100.00% <0.00%> (ø)
utils/timeProvider.go 0.00% <0.00%> (ø)
routers/api/v1/router.go 100.00% <0.00%> (ø)
routers/frontend/router.go 100.00% <0.00%> (ø)
services/sendgrid/v2/emailService.go 90.41% <0.00%> (+0.82%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091d73a...9946a8f. Read the comment docs.

Copy link
Collaborator

@kzalys kzalys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

routers/api/v2/users.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kzalys kzalys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seanjparker seanjparker merged commit 512194b into master Oct 13, 2020
@seanjparker seanjparker deleted the feat/special-permissions-v2 branch October 13, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-v2 Issues relating to the Auth V2 design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API V2 - Special User Permissions
2 participants