Unity 2022.3.10 offsets and/or changes #20
Conversation
|
So the first step to define a new version is to add a new Once this is done, you can add it to the Normally, these are the only places you should need to modify. If there are other pieces of the code that don't work with that new version, we'll need to investigate more thoroughly. |
| @@ -81,16 +81,16 @@ public TypeDefinition GetTypeDefinition(IntPtr address) | |||
| { | |||
| var definitions = new ConcurrentDictionary<IntPtr, TypeDefinition>(); | |||
| int classCache = this.Process.MonoLibraryOffsets.ImageClassCache; | |||
| var classCacheSize = this.ReadUInt32(classCache + this.Process.MonoLibraryOffsets.HashTableSize); | |||
| var classCacheTableArray = this.ReadPtr(classCache + this.Process.MonoLibraryOffsets.HashTableTable); | |||
| var classCacheSize = this.ReadUInt32(/*classCache + this.Process.MonoLibraryOffsets.HashTableSize*/1256); | |||
There was a problem hiding this comment.
Here I only know the good values for classeCache + HashTableSize and classCache + HashTableTable but I have no idea about the individual values of each offset
| @@ -65,6 +65,7 @@ public TypeDefinition([NotNull] AssemblyImage image, IntPtr address) | |||
| // Get the generic type arguments | |||
| if (this.TypeInfo.TypeCode == TypeCode.GENERICINST) | |||
| { | |||
| this.fieldCount = this.ReadInt32(96); | |||
There was a problem hiding this comment.
Here I can't simply use 96 for the TypeDefinitionFieldCount offset since this line isn't always executed at the same time as the line that uses TypeDefinitionFieldCount
| @@ -193,7 +194,7 @@ private IReadOnlyList<FieldDefinition> GetFields() | |||
| } | |||
|
|
|||
| var fields = new List<FieldDefinition>(); | |||
| if (this.ClassKind == MonoClassKind.GInst) | |||
| if (this.ClassKind is MonoClassKind.GInst or MonoClassKind.GParam) | |||
There was a problem hiding this comment.
This isn't simply an offset change
| @@ -248,13 +249,15 @@ private IEnumerable<TypeDefinition> NestedHierarchy() | |||
|
|
|||
| private TypeDefinition GetGeneric() | |||
| { | |||
| if (this.ClassKind != MonoClassKind.GInst) | |||
| if (this.ClassKind is MonoClassKind.GInst or MonoClassKind.GParam) | |||
There was a problem hiding this comment.
This isn't simply an offset change
| @@ -308,8 +308,7 @@ private int GetSize(TypeCode typeCode) | |||
|
|
|||
| case TypeCode.U: | |||
| case TypeCode.U4: | |||
| return sizeof(uint); | |||
|
|
|||
| return 8; | |||
There was a problem hiding this comment.
This doesn't seem to be bound to offsets
This PR contains all the changes I made to make unity spy work on a game using Unity 2022.3.10.
I'm unsure how to create a complete new offset object and would need help with it (I commented the offsets I had to replace with the values I figured out).
There are also some non-offset changes, these probably need some work/testing to make them compatible with all other supported unity versions.