Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link accounts and stop Google account creation from the sign in page #703

Closed
1 of 2 tasks
Tracked by #739
erikguntner opened this issue May 29, 2024 · 1 comment · Fixed by #726
Closed
1 of 2 tasks
Tracked by #739

Link accounts and stop Google account creation from the sign in page #703

erikguntner opened this issue May 29, 2024 · 1 comment · Fixed by #726
Assignees
Labels
Complexity: Small Issue has detailed instructions to resolve and the task is simple. p-Feature: Host Registration Issue related to Host Registration points: 2 Can be done in 7-12 hours Role: Back End

Comments

@erikguntner
Copy link
Collaborator

erikguntner commented May 29, 2024

Overview

Currently, users who sign in using a Google account that isn't associated with an existing account creates a user that has no role.
We can account for this in two ways:

  1. Linking accounts in the case the user wants to attach a Google account to their current email and password account.
  2. If the user has not been saved in our database, meaning they haven't gone through the sign up process, we delete the created AWS user and throw an error.

Action Items

  • Create a pre-sign-up lambda function to link AWS user accounts
  • In the sign in endpoint, check if a user exists in our db, if not, delete the AWS user and throw error.

Resources/Instructions

@sanya301
Copy link
Member

sanya301 commented Jun 5, 2024

Can you post update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Issue has detailed instructions to resolve and the task is simple. p-Feature: Host Registration Issue related to Host Registration points: 2 Can be done in 7-12 hours Role: Back End
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants