-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Link Colors Consistent #1452
Comments
I also set the :hover color to "#004ba0" |
@Seiko I'm putting this back to "In Progress", cause we need to know what the colors should be for each of the following states: |
Here is a link that talks about styling links: https://developer.mozilla.org/en-US/docs/Learn/CSS/Styling_text/Styling_links Apparently, there is no such thing as a "disabled" link, but there an additional state called "active" for when the link is clicked on, and only the normal and visited states are mutually exclusive. For example, a link can be visited and focused and active at the same time. I just styles the focused and active states with bolder text, and uses a color of primary.light = "#6693CA" for the active state. |
I changed Disable gray to Secondary link (HEX #4D4D4D) https://www.figma.com/file/D3oq9QOXl0rFkwrEUJbABs/FOLA-Design-%231?node-id=10336-17624&t=GchKTlaug1NNGW6R-4 We use this secondary link on the static pages. This is used in blocks of text. |
I checked dev site and have several requests.
|
@sei1122 It wasn't clear to me exactly what behavior you want with the "secondary" link, but I used the color you specified for the normal state, and took out any color changes, etc. for the other states (hover, click, visited, etc.) So for the secondary link the only thing that changes with the link state is that the cursor changes to a finger when it is hovered. Similarly, for the link to be used with images or icons, the only state-driven behavior should be the cursor change. |
Hi @entrotech, sorry it has been a while to reply this issue. |
Create the development issue to get rid of the secondary link color. |
|
Overview
Standardize Link colors to #1976D2 for normal links and #551A8B for "visited" links throughout the Food Seeker and Volunteer and Admin themes and make sure the themes are applied to all instances of links. If there are links that appear on non-white backgrounds that have insufficient contrast, make a note of them and we will discuss.
Action Items
Resources/Instructions
(https://www.figma.com/file/D3oq9QOXl0rFkwrEUJbABs/FOLA-Design-System?node-id=2943%3A7817&t=W0esMVtJzkzGG3TE-0)
The text was updated successfully, but these errors were encountered: