Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Link Colors Consistent #1452

Closed
2 tasks done
entrotech opened this issue Nov 30, 2022 · 10 comments · Fixed by #1639
Closed
2 tasks done

Make Link Colors Consistent #1452

entrotech opened this issue Nov 30, 2022 · 10 comments · Fixed by #1639
Assignees
Labels
Dependency This issue has other issues that need to be resolved before it can be worked. dev Code Development Feature: Design System Standards, documentation and guide of design assets and components Release Note: Enhancement Shows on Release Notes under "Enhancements" Role: Front-end Front End Developer size: 2pt The lift to complete this user story 3-4hrs Sprint 01

Comments

@entrotech
Copy link
Member

entrotech commented Nov 30, 2022

Overview

Standardize Link colors to #1976D2 for normal links and #551A8B for "visited" links throughout the Food Seeker and Volunteer and Admin themes and make sure the themes are applied to all instances of links. If there are links that appear on non-white backgrounds that have insufficient contrast, make a note of them and we will discuss.

Action Items

  • Define the colors in the /client/src/theme/clientTheme and /client//src/theme/adminTheme theme files and then modify react components that have links to use the styles from the Material-UI themes.
  • The most important point is to make sure that all links get their style from the theme, rather than having hard-coding styling unique to different links in the site, We expect the Design Team to change their mind about what exact color should be used, but it should be the case that we change a color in one (or maybe two - one for food Seeker (clientTheme) and one for admin (adminTheme) places).

Resources/Instructions

(https://www.figma.com/file/D3oq9QOXl0rFkwrEUJbABs/FOLA-Design-System?node-id=2943%3A7817&t=W0esMVtJzkzGG3TE-0)

@entrotech entrotech added Release Note: Enhancement Shows on Release Notes under "Enhancements" dev Code Development Role: Front-end Front End Developer size: 2pt The lift to complete this user story 3-4hrs Feature: Design System Standards, documentation and guide of design assets and components labels Nov 30, 2022
@entrotech entrotech added the Dependency This issue has other issues that need to be resolved before it can be worked. label Dec 20, 2022
@entrotech
Copy link
Member Author

I also set the :hover color to "#004ba0"

@entrotech
Copy link
Member Author

@Seiko I'm putting this back to "In Progress", cause we need to know what the colors should be for each of the following states:
normal link: "#1976D2";
visited link: "#551A8B";
hovered link: ??
disabled link: ??

@sei1122
Copy link
Member

sei1122 commented Feb 27, 2023

Can you set the link color to these?
We may need to adjust later but I'd like to try this
Normal link: "#1976D2";
Visited link: "#551A8B";
Hovered link: #004BA0
Disabled link: #4D4D4D

Screen Shot 2023-02-26 at 11 10 17 PM

@entrotech
Copy link
Member Author

Here is a link that talks about styling links: https://developer.mozilla.org/en-US/docs/Learn/CSS/Styling_text/Styling_links

Apparently, there is no such thing as a "disabled" link, but there an additional state called "active" for when the link is clicked on, and only the normal and visited states are mutually exclusive. For example, a link can be visited and focused and active at the same time. I just styles the focused and active states with bolder text, and uses a color of primary.light = "#6693CA" for the active state.

@sei1122
Copy link
Member

sei1122 commented Mar 20, 2023

@entrotech,

I changed Disable gray to Secondary link (HEX #4D4D4D)

https://www.figma.com/file/D3oq9QOXl0rFkwrEUJbABs/FOLA-Design-%231?node-id=10336-17624&t=GchKTlaug1NNGW6R-4
Screen Shot 2023-03-19 at 8 18 05 PM

We use this secondary link on the static pages. This is used in blocks of text.

Screen Shot 2023-03-19 at 8 19 50 PM

@sei1122 sei1122 reopened this Mar 20, 2023
@sei1122
Copy link
Member

sei1122 commented Mar 20, 2023

I checked dev site and have several requests.

  1. Can you remove this green when hovering the link

Screen Shot 2023-03-19 at 8 22 37 PM

  1. Underline should be the same as the phone number
  2. Remove underlines from social media icons

Screen Shot 2023-03-19 at 8 28 28 PM

@entrotech
Copy link
Member Author

@sei1122 It wasn't clear to me exactly what behavior you want with the "secondary" link, but I used the color you specified for the normal state, and took out any color changes, etc. for the other states (hover, click, visited, etc.) So for the secondary link the only thing that changes with the link state is that the cursor changes to a finger when it is hovered.

Similarly, for the link to be used with images or icons, the only state-driven behavior should be the cursor change.

@sei1122
Copy link
Member

sei1122 commented May 4, 2023

Hi @entrotech, sorry it has been a while to reply this issue.
I checked the links, and I'd like to update this secondary link to the primary link so that the links are consistent.
Since our site is not big, just one link color is fine now.

Screen Shot 2023-05-04 at 3 26 33 PM

@sei1122
Copy link
Member

sei1122 commented May 16, 2023

Create the development issue to get rid of the secondary link color.

@sei1122 sei1122 reopened this May 16, 2023
@sei1122 sei1122 added the Ready for dev lead Issue ready for dev lead to review label May 16, 2023
@entrotech
Copy link
Member Author

@qiqicodes qiqicodes closed this as completed by moving to Done in P: FOLA: Project Board May 31, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the Ready for dev lead Issue ready for dev lead to review label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency This issue has other issues that need to be resolved before it can be worked. dev Code Development Feature: Design System Standards, documentation and guide of design assets and components Release Note: Enhancement Shows on Release Notes under "Enhancements" Role: Front-end Front End Developer size: 2pt The lift to complete this user story 3-4hrs Sprint 01
Projects
Development

Successfully merging a pull request may close this issue.

4 participants