Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty state to list view when there are no results #764

Closed
bbovenzi opened this issue Oct 28, 2020 · 5 comments · Fixed by #793
Closed

Add empty state to list view when there are no results #764

bbovenzi opened this issue Oct 28, 2020 · 5 comments · Fixed by #793
Assignees
@hanapotski
Labels
good first issue Good for newcomers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer

Comments

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 28, 2020 •
edited
Loading

Problem: Currently if you go a to a location without any organizations we show a blank screen for the list view (see below)

Solution: Add some text like "Sorry, we don't have any results for this area. Click here to reset the search". On the reset we can do a search with the defaultCoordinates

Screen Shot 2020-10-28 at 1 37 58 PM
@bbovenzi bbovenzi added Role: Front-end Front End Developer good first issue Good for newcomers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") labels Oct 28, 2020
@sasi-jj
Copy link

sasi-jj commented Oct 29, 2020 •
edited
Loading

Hi @bbovenzi , i would like to contribute in this work.

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Nov 5, 2020 •
edited
Loading

@sasi-jj go for it! Let me know if you have any issues getting the app running

@sasi-jj
Copy link

sasi-jj commented Nov 5, 2020

Ok i will do 😁

@sasi-jj
Copy link

sasi-jj commented Nov 13, 2020 •
edited
Loading

@bbovenzi Need help with NO_TOKEN_WARNING issue in dev - changes made for empty state need to test with list view

@bbovenzi
Copy link
Contributor Author

@sasi-jj sent you an email with the .env variables

@hanapotski hanapotski self-assigned this Dec 16, 2020
@hanapotski hanapotski mentioned this issue Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanapotski hanapotski

Labels
good first issue Good for newcomers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer
Projects
P: FOLA: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add loading and empty states hackforla/food-oasis
3 participants
@bbovenzi @sasi-jj @hanapotski