-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show distances from location searched (not just center of map) #926
Comments
Yeah, the logic here is somewhat of a historical remnant from before we implemented the "Search the Area" button, when the center of the map always was the "user's location". Now we need to keep track of the user's location (starting point or origin) separately from the center of the map. we need to re-examine how the interaction works. Maybe:
|
Yes, your interaction outline sounds good to me with some comments below — definitely want some marker of the user-submitted location on there. Might consider if we can/should separate the “search for address” from the geolocation button, which is how the Google and Apple Maps apps work. Ideally we could have two different types of indicators since that’s what folks are used to (see below): Bullet 3 could be a separate chunk as we don’t have a ‘re-center’ button (yet). Bullet 4: If the user disallowed the location earlier, then it’d be nice to ask again if the user requests geolocation, then cancel out and keep map unchanged (as opposed to changing location to middle of LA) if they deny it once again. |
Related to |
Based on John and Bryan's comments above, I worked on the following four cases: 1. Geolocation disabled + no user-entered address
A screenshot with the distances removed. 2. Geolocation enabled + no user-entered address
3. Geolocation disabled + user-entered address
4. Geolocation enabled + user-entered address
Additional questions: When switching from case 2 to case 4, will users get confused about whether the distances are with respect to the red pin or the blue dot? Should we be more specific when displaying the distances? Figma file: https://www.figma.com/file/D3oq9QOXl0rFkwrEUJbABs/Fola-Design-System?node-id=2935%3A5 |
Love the exhaustive use cases and mockups! Thanks! From the weekly meeting: @entrotech mentioned that we don’t currently support ‘live’ geolocation (blue dot moves automatically as user moves), so that could simplify things for us by removing case 4. Case 2 (geolocation) in this case might be merged into case 3, but with the address field filled out by the computer? I think we’d want to avoid the blue dot in this case since that typically indicates ‘live’ tracking (I noticed that blue dots are usually animated, too) One question that came up was whether to use the red marker as the center of the map when user didn’t enter anything. For me, I think that your case 1 does it well — no marker needed and it follows in the footsteps of other map apps. ( Or perhaps use a different colored marker to distinguish it from a user-entered address? ) If we want to get fancy, I wonder if we can
@gigicobos also wondered if we had analytics about how many people use the ‘locate me’ Personally, I use that feature frequently on other sites, often for finding 'stores near me' :) |
Related to / duplicate of |
hi, Great job again @souronion !! Following @fancyham comments
Analytics Questions @entrotech |
Correct. Geolocation now finds user location and marks that location on the map with the red pin. It basically uses GPS to find a street address or lat/long and in effect, enters it into the search field turning case 2 into a version of case 3. |
@souronion here are my comments to your questions and mock-up ideas :) : 1. Geolocation disabled + no user-entered address: Should we hide the distances in this case? --> I support hiding the distances in that case. We can discuss more tonight. |
Thanks for the great suggestions, everyone!! I updated the cases based on our discussion last week. 1. Geolocation disabled + no user-entered address (same as the previous version)
2. Geolocation enabled + no user-entered address (merged with case 3)
Change from the first version: Replaced the blue dot with a red marker. I like @fancyham's suggestion that we automatically display the user's address in the search bar. 3. Geolocation disabled + user-entered address (same as the previous version)
4. Geolocation enabled + user-entered address (now the same as Case 3)
Change from the previous version: Hide the user's current location (the blue dot) I like @gigicobos's suggestion that we change the icon so that it does not look like a selected food pantry. I'll work on the icon in the following week. :) |
For the question about reverse-geolocating: @entrotech said that how location is turned back into text depends on the service. Depending on the service, might return an approximate street address, a cross street, or maybe lat/long. We agreed with @souronion’s suggestion that if the address becomes too complex or non-useful for a human, that we can put a red pin down but leave the address field blank (as shown in scenario 2 above were address field is blank) |
@souronion hey - Can you please add a size label to your issue |
@Benbaillou I think that the size estimate is really more of an @entrotech thing at this point since the design is complete and it’s entering development. (I’ve been thinking of the size as a development estimate, not a design one, BTW — but if we were to have ‘design size' estimate labels, I’d be happy to use them) |
@fancyham thank you for your feedback. I withdrew the label 'role design' and I let @entrotech size the issue. Good idea for the size label per role, we just need to make sure it does not bring too much confusion. |
@Benbaillou I think that UX design is very much part of this. I’m just saying that the size in this issue is primarily determined by how easy or hard it is to write the code changes. The design itself in comparison is relatively easy (and also already complete) |
Got it, thanks Bryan for the clarifications :) |
Hi folks from the dev meeting. As promised, here’s the general gist from the user’s perspective: It’s like Google Maps:
In effect, this boils down to two states: No-user-address: Address text field is blank or has an unresolvable address:
Have-user-address: Address text field is filled with a resolvable address:
How does the address field work? The address text field can be filled by…
How does the URL work? (stretch goal) Note that the URL method could result in either state, depending on how specified:
Nice to have: URL in browser updates when address is entered (like Google Maps) for easy copy/pasting/bookmarking In the future, it may be possible to clear the address field, meaning that it might switch states from Have-user-address to No-user-address Please ping souronion or me if anyone has questions. |
Hi team, I just uploaded the red marker's SVG onto the Fola Hfla Share Drive: https://drive.google.com/file/d/17Oh8oQ4m3AEMNrtZxgtLne3_KOaz7lhv/view?usp=sharing |
During our meeting, it seemed the general expectation was that the distances shown on the list of locations were from the address the user entered into the search field. However, that is not actually the case one the user has panned the map.
How it is now
Currently, the distance shown on the list for each location is from the center of the map, not from the address the user has entered.
This can be misleading, especially as the user pans around or broadens their search area by zooming out and panning.
Discussion
One part of this problem is that we currently do not put a marker on the map of the user-entered address nor their current location.
A second part of this problem is finding user's expectations and the processing power required to meet it.
A third part of this is what users expect the list order to mean. Is it: "locations on the map in order of distance from the user-entered address, even if that address is currently off the screen"?
Solutions?
A short-term solution might be to remove the distances once the user pans the map or if user did not enter a location.
Long term:
The text was updated successfully, but these errors were encountered: