-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greyed out text explanations #1244
Comments
@awikstrom-ladot will provide a document with the Appendix C table in it so that HfLA team can create a document for tooltip text. |
Link to the Appendix C table doc: https://docs.google.com/document/d/1JPBUCZJjRq_4pWqMDuh4Qr3ffkIFMbB0/edit |
@ExperimentsInHonesty @SMR9220 @awikstrom-ladot StrategyAppllicabilityRules.csv The displayFunctionBody column of this csv file gives a Javascript expression that is evaluated to determine if the strategy is applicable (i.e. not greyed out in tht UI). The tokens in double angle brackets represent the value of other rules. In most cases, whether a strategy is applicable is a function of the project land uses, though in several cases, the function implements strategies that are mutually exclusive with other rules. Strategies that are always applicable have a displayFunctionBody of 'return true'. The land use applicability should agree with the document @awikstrom-ladot referenced above, but the custom applicability rules are documented piecemeal on individual issues and I don't think LADOT/City Planning has a document describing these situations. Some of the tooltips (e.g. Mandatory Trip Reduction) already include language in the tooltip describing how various strategies are mutually exclusive. To make this issue actionable for developers, we would need to specify how the applicabilty rules for strategies should be worded in the tooltips. |
It is possible to have different tooltips depending on whether a strategy is applicable or not, but IMO, it would be more helpful if the same tooltip applied in either case and the applicability was added to the description of the strategy in the tooltip. |
During today's meeting, Xander agreed that it is okay to add a text to the top of the tooltip that explains why the strategy is greyed-out. They would update the TDM Tooltip Edits for Greyed out text with the appropriate text. |
TDM Tooltip Edits for Greyed out text has been updated with the appropriate text that explains why the strategy is greyed out. |
Emily also left this comment : 'Unexpected issue I encountered when testing the greyed out strategies with different project uses: Please think about possible solutions for this issue. Two I can think of are (1) forcibly removing any strategies that are no longer valid when a project's uses change, or (2) putting up a big error message that flags for someone that they should reset their project or at least the page if this scenario occurs. Thanks!' |
Issue #1265 addresses the concerns in Emily's comments above |
All the new changes to the tooltips are in this document, go ahead and make the changes in the db For reading the changes in the document Stakeholder Emily pointed out that if content is removed it's got a strike-through, otherwise it's an addition. |
Notes from 2023-01-10 meeting with stakeholder
|
Overview
Users are unsure why certain strategies on pg 4 of the application are greyed out.
Action Items
tooltip title
)---
in theNon-Applicable Land Use
ColumnStakeholder
Resources/Instructions
The text was updated successfully, but these errors were encountered: