Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize code for header layout #1898

Closed
4 tasks done
arghmatey opened this issue Jul 7, 2021 · 8 comments · Fixed by #2002
Closed
4 tasks done

Standardize code for header layout #1898

arghmatey opened this issue Jul 7, 2021 · 8 comments · Fixed by #2002

Comments

@arghmatey
Copy link
Contributor

arghmatey commented Jul 7, 2021

Overview

Create standardized header layout component html and css to ensure visual consistency, and to make creating new pages easier and more efficient.

Action Items

Resources/Instructions

Issues with current header layout commented on #1791

@arghmatey arghmatey self-assigned this Jul 7, 2021
@arghmatey arghmatey added Feature: Design system role: front end Tasks for front end developers labels Jul 7, 2021
@arghmatey arghmatey changed the title Standardize header layout Standardize code for header layout Jul 8, 2021
@arghmatey
Copy link
Contributor Author

arghmatey commented Jul 14, 2021

HTML code and reusable class names are complete for the page header.

@github-actions
Copy link

@arghmatey Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@Sihemgourou
Copy link
Contributor

Hi @arghmatey, please add a size to the issue :) thanks!

@arghmatey
Copy link
Contributor Author

@Sihemgourou Done!

Meeting with Danielle tomorrow to discuss my previous comment. If all is good, PR to be submitted tomorrow afternoon.

@Sihemgourou
Copy link
Contributor

perfect thanks ! don't hesitate to use this template for next time

  1. Progress
  2. Blockers
  3. Availability
  4. ETA
    Thanks :)

@Sihemgourou Sihemgourou added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Jul 20, 2021
@github-actions github-actions bot added Test: Update Label and removed Status: Updated No blockers and update is ready for review Test: Update Label labels Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

@arghmatey

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 3, 2021 at 7:53 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@abuna1985
Copy link
Member

abuna1985 commented Aug 11, 2021

The dependency tag has been removed from #19

@abuna1985
Copy link
Member

abuna1985 commented Aug 11, 2021

Updated How to create a page on the HfLA website wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants