-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Program Areas page so the projects are dynamically rendered #2485
Comments
Hi @macho-catt. Good job adding the required labels to this issue. Additional Resources: |
This comment was marked as outdated.
This comment was marked as outdated.
Progress: Currently I have created a branch and am now going to look into how to solve the issue |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @amnak1284, just wanted to see what your progress on this issue is? |
This comment was marked as outdated.
This comment was marked as outdated.
@amnak1284 since this has been inactive for a while, I will unassign you. Please feel free to pick up this issue again when you have the time. Thanks |
As I said on the call, the changes in I created issue #3587 to have docker-compose updated to do this on it's own before building and serving. Until this is merged you can simply run |
Awesome, thanks so much for the explanation and insight! |
@kathrynsilvaconway @blulady @arpitapandya I am almost ready to open a pull request, however I wanted to propose a possible list of "good second issues".
whereas 311-data.md shows
|
This is a great idea, let's chat about it tonight and see what Kathryn thinks. |
Hi Devs, and specifically @jdingeman After we had a conversation at one of our meeting about how to do it, a different approach was taken than is mentioned above. I want to make sure that an explanation of that method is documented in the wiki. If it is not, please make an issue for that to be done. |
@ExperimentsInHonesty - this method written has now been written into the wiki. See page here |
@hackforla/website-merge I think the wiki page that @jdingeman made is perfect. We need to make sure a link to it is added to the future content that will be here https://github.com/hackforla/website/wiki/Pages-on-Hack-for-LA-website, or temporarily add it to https://github.com/hackforla/website/wiki/Hack-for-LA's-Site-Architecture#pages |
@ExperimentsInHonesty - link has been added under "Program Areas" https://github.com/hackforla/website/wiki/Pages-on-Hack-for-LA-website |
Overview
The Program Areas page mini cards need to be rendered dynamically so they match the results from the project filters.
Details
Currently, the program-areas.html file use liquid to loop through each program area yml file under _data/internal/program-areas/. Projects for each program area are declared in the yml file. However, if we add a new project under the _projects collection and declare their program area, we also need to update the proper program area yml file. Additionally, if we ever need to change a project's program area, we need to ensure that the program area yml files are updated as well.
Since this becomes unmaintainable in the long run, it would be smarter if the program-areas.html file renders the mini page cards for each project by referencing the _projects collection instead of the program area yml files.
Action Items
Resources/Instructions
program-areas.html
_data/internal/program-areas/
_projects collection
Liquid in Jekyll
Iteration in Liquid
The text was updated successfully, but these errors were encountered: