Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Project meeting data from VRMS is not updating #3890

Closed
4 tasks done
Tracked by #4028
ExperimentsInHonesty opened this issue Jan 29, 2023 · 7 comments · Fixed by #3939
Closed
4 tasks done
Tracked by #4028

Bug: Project meeting data from VRMS is not updating #3890

ExperimentsInHonesty opened this issue Jan 29, 2023 · 7 comments · Fixed by #3939
Assignees
Labels
Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 29, 2023

Overview

We need to find and fix the data on the project's page for events not updating , so that people who are looking to join teams have accurate meeting data.

Details

The meeting time is showing up on the Events page but not on the project page. Which means the API is working, but somehow we are not updating the data used on the projects page.

Action Items

  • Identify and document how to replicate problem
  • Identify and document source files
  • Identify and document what it should be doing
  • Figure out what is broken

Resources/Instructions

Replicating problem

  1. Logging into VRMS
  2. Seeing the meeting data it provides
VRMS team page in VRMS.io application Screen Shot 2023-01-24 at 9 05 28 AM
  1. Checking the meetings against what appears on the website for the project page
VRMS page on hackforla.org website Screen Shot 2023-01-24 at 9 05 33 AM
  1. Checking the meetings against what appears on the hackforla.org Events page
Sunday meetings list

image

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Jan 29, 2023
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Jan 29, 2023
@ExperimentsInHonesty ExperimentsInHonesty self-assigned this Jan 29, 2023
@github-actions

This comment was marked as resolved.

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Jan 29, 2023

Double check that the Events page is using the same api as the project page via is js file.

https://github.com/hackforla/website/blob/gh-pages/assets/js/project.js#L125

Its using the same api, but it might be calling the data seperately instead of using the file https://github.com/hackforla/website/blob/gh-pages/_data/external/vrms_data.json that is created by the 2am pst chron job (GHA: https://github.com/hackforla/website/blob/gh-pages/.github/workflows/vrms-data.yml)

@ExperimentsInHonesty ExperimentsInHonesty removed their assignment Jan 29, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the time sensitive Needs to be worked on by a particular timeframe label Jan 29, 2023
@MattPereira MattPereira self-assigned this Feb 5, 2023
@github-actions

This comment was marked as outdated.

@MattPereira
Copy link
Contributor

Availability: 7 - 9 PM Sunday - Thursday
ETA: asap

@MattPereira
Copy link
Contributor

MattPereira commented Feb 5, 2023

@ExperimentsInHonesty

There is a meeting object in the vrms_data.json array that looks like this

image

Since the project key of this meeting object has a null value, an error is thrown on the 56th iteration of the for loop that appends the meetings to the project page

for (let i = 0; i <= scheduleData.length - 1; i++) {

let webURL = scheduleData[i].project.hflaWebsiteUrl;

The unhandled error results in the for loop exiting before the final 57th iteration runs, which is the iteration that would append the infamous "Sun 7:00 pm - 8:00 pm testing" that is currently missing from the VRMS project page.

You can see this error on the live site if you visit https://www.hackforla.org/projects/vrms and open the browser console.
image

@MattPereira
Copy link
Contributor

Let me know if I should merge my own PR since this fix is needed ASAP or if you'd prefer I wait for reviews

@MattPereira
Copy link
Contributor

MattPereira commented Feb 5, 2023

I also just noticed that the projectTitle "Access The Data" does not match casing with the VRMS data for project.name so I am adding a .toLowerCase() method to both the projectTitle and projectName to fix it.

You can see Access the Data meeting times are currently broken on the live site: https://www.hackforla.org/projects/access-the-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

2 participants