Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBB migration "Schedule Friday" #7055

Merged
merged 6 commits into from
Jun 23, 2024
Merged

PBB migration "Schedule Friday" #7055

merged 6 commits into from
Jun 23, 2024

Conversation

t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Jun 23, 2024 •
edited
Loading

Fixes #6998

OK for reviewing, But do not Merge

What changes did you make?

  • In schedule-fri-0700.yml remove the "IN_PROGRESS_COLUMN_ID"
  • In add-label.js, refactored the code to retrieve all issues from repo and then added a complementary section to exclude certain labels
  • Same file, added logic to prevent automation from attempting to remove labels that are not present
  • Same file, applied housekeeping to make the console.log()s consistent

Why did you make the changes (we will use this info to test)?

  • The new PBB does not use 'columns'; this will need refactoring
  • The refactoring was needed b/c the new PBB does not recognize columns
  • For consistency in grammar, comment structure, etc.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-pbb-migration-schedule-friday-6998 gh-pages
git pull https://github.com/t-will-gillis/website.git pbb-migration-schedule-friday-6998

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large Dependency An issue is blocking the completion or starting of another issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 8pt Can be done in 31-48 hours Draft Issue is still in the process of being created role: back end labels Jun 23, 2024
@t-will-gillis
Update add-label.js
a71fb06 
remove refs to personal repo
@t-will-gillis
Update add-label.js
ae86574 
addressing CodeQL alert
@t-will-gillis
Update add-label.js
612e26e 
address CodeQL alert
@t-will-gillis t-will-gillis merged commit 5f683ba into hackforla:gh-pages Jun 23, 2024
4 checks passed
@t-will-gillis t-will-gillis removed Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created labels Jun 23, 2024
@t-will-gillis t-will-gillis deleted the pbb-migration-schedule-friday-6998 branch June 23, 2024 20:16
This was referenced Jun 28, 2024
Closed
Closed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
@t-will-gillis @terrencejihoonjung
PBB migration "Schedule Friday" (hackforla#7055)
815bde9 
* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santisecco @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>
Co-authored-by: David Cotelessa <david@cotelessa.com>
Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com>
Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com>
Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com>
Co-authored-by: williamzhang <willzhang73@gmail.com>
Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com>
Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com>
Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com>
Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com>
Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com>
Co-authored-by: duojet2ez <epstringskip@gmail.com>
Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com>
Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com>
Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com>
Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 8pt Can be done in 31-48 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Board Migration: refactoring of "Schedule Friday 0700" workflow
1 participant
@t-will-gillis