Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate contributor's name in filter tag with ellipsis on Toolkit page #7052

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Truncate contributor's name in filter tag with ellipsis on Toolkit page #7052

merged 1 commit into from
Jul 10, 2024

Conversation

aadilahmed
Copy link
Member

Fixes #6787

What changes did you make?

  • Added "text-overflow: ellipsis" and "white-space: nowrap" styles to .filter-tag element in _toolkit.scss to truncate a contributor's name with ellipsis
  • Changed "max-width" value from "fit-content" to "300px" to make sure truncation of longer names occurs
  • Made the "::after" cross element into a "::before" element that floats right so that it shows up when the contributor's name is truncated

Why did you make the changes (we will use this info to test)?

  • To provide a visual cue when a contributor's name is truncated

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screenshot 2024-06-22 at 20-46-27 Toolkit - Hack for LA

Visuals after changes are applied

Screenshot 2024-06-22 at 20-46-17 Toolkit - Hack for LA

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aadilahmed-manage-contributor-name-truncation-6787 gh-pages
git pull https://github.com/aadilahmed/website.git manage-contributor-name-truncation-6787

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ size: 2pt Can be done in 7-12 hours labels Jun 23, 2024
@A-Wu5 A-Wu5 self-requested a review June 24, 2024 01:00
@A-Wu5
Copy link
Member

A-Wu5 commented Jun 24, 2024

ETA: 6/26
Availability: 6-8PM M-F

@roslynwythe roslynwythe self-requested a review June 26, 2024 02:25
A-Wu5
A-Wu5 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@A-Wu5 A-Wu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aadilahmed! Great work on this issue. The changes are clean and looks good to me.

@jphamtv
Copy link
Member

jphamtv commented Jun 27, 2024

Hi @roslynwythe - When you have a moment, please provide your availability and ETA for review. Thanks!

@Thinking-Panda Thinking-Panda self-requested a review July 10, 2024 20:31
Thinking-Panda
Thinking-Panda approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadilahmed , Nice work on the issue. Merge branches look correct. Code changes give expected output on my local machine. Approved!

@Thinking-Panda Thinking-Panda merged commit 4b255e4 into hackforla:gh-pages Jul 10, 2024
10 checks passed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 13, 2024
@aadilahmed @terrencejihoonjung
truncate contributors name in filter tag with ellipis (hackforla#7052)
501535a
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santisecco @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>
Co-authored-by: David Cotelessa <david@cotelessa.com>
Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com>
Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com>
Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com>
Co-authored-by: williamzhang <willzhang73@gmail.com>
Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com>
Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com>
Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com>
Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com>
Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com>
Co-authored-by: duojet2ez <epstringskip@gmail.com>
Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com>
Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com>
Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com>
Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thinking-Panda Thinking-Panda Thinking-Panda approved these changes

@A-Wu5 A-Wu5 A-Wu5 approved these changes

@roslynwythe roslynwythe Awaiting requested review from roslynwythe

Assignees
No one assigned
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage truncation of contributors name in filter tag on toolkit page
4 participants
@aadilahmed @A-Wu5 @jphamtv @Thinking-Panda