Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: create stats dashboard page #962

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

chenxuan-zhou
Copy link

@chenxuan-zhou chenxuan-zhou commented Nov 16, 2021

Tickets:

List of changes:

  • added admin stats page to display application counts
  • added application count of current day
  • added line graph of application count of past 30 days
  • merged in demographic stats from PR 961

Type of change:

Please delete options that aren't relevant.

  • New feature (non-breaking change which adds functionality)

How did you do this?

Created the Stats and StatsApplicationGraph components in features.
Added a new "/admin/stats" route for the Stats component.

How to test:

Automatic test at PR.

Questions:

I did not push the changes done by linting since many code that I didn't touch were also changed and there were many errors. Do I need to worry about this?

I had an interface that I would like to share between Stats and StatsApplicationGraph. Is there a good way of doing so? (Currently I just copied the interface over)

PR Checklist:

  • Merged develop branch (before testing)
  • Linted my code locally
  • Listed change(s) in the Changelog
  • Tested all links in project relevant browsers
  • Tested all links on different screen sizes
  • Referenced all useful info (issues, tasks, etc)

Screenshots:

Search _ McHacks — Mozilla Firefox 11_29_2021 4_07_36 PM
Search _ McHacks — Mozilla Firefox 11_29_2021 4_07_41 PM

@pierreTklein
Copy link
Member

pierreTklein commented Nov 19, 2021

You can add & export an interface as a separate file and then import it into both files you want to use it. We do this for other interfaces too!

@chenxuan-zhou
Copy link
Author

You can add & export an interface as a separate file and then import it into both files you want to use it. We do this for other interfaces too!

Thank you Theo! I put the interface in a separate file in the latest commit. Does the export style look correct?

@chenxuan-zhou chenxuan-zhou force-pushed the feat/950-create-stats-dashboard-page branch from 16eb3be to 78bd5f2 Compare November 26, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants