-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: create stats dashboard page #962
Open
chenxuan-zhou
wants to merge
15
commits into
develop
Choose a base branch
from
feat/950-create-stats-dashboard-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can add & export an interface as a separate file and then import it into both files you want to use it. We do this for other interfaces too! |
Thank you Theo! I put the interface in a separate file in the latest commit. Does the export style look correct? |
chenxuan-zhou
force-pushed
the
feat/950-create-stats-dashboard-page
branch
from
November 26, 2021 02:33
16eb3be
to
78bd5f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
List of changes:
Type of change:
Please delete options that aren't relevant.
How did you do this?
Created the Stats and StatsApplicationGraph components in features.
Added a new "/admin/stats" route for the Stats component.
How to test:
Automatic test at PR.
Questions:
I did not push the changes done by linting since many code that I didn't touch were also changed and there were many errors. Do I need to worry about this?
I had an interface that I would like to share between Stats and StatsApplicationGraph. Is there a good way of doing so? (Currently I just copied the interface over)
PR Checklist:
develop
branch (before testing)Screenshots: