Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce env vars. #88

Merged
merged 1 commit into from
May 21, 2018
Merged

reduce env vars. #88

merged 1 commit into from
May 21, 2018

Conversation

BrianHGrant
Copy link
Member

This commit would reduce the number of env vars, taking out the "Development" vs. "Production". Updated the README.

This is partially in response to:
#13 (comment)

If we merge, will mean that you will need to change the .env variables when going from dev to prod build, when running locally.

Copy link
Contributor

@MikeTheCanuck MikeTheCanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads well and looks simpler. If I wasn’t on a plane I’d test the sample app to be sure these changes didn’t break it; if other reviewers are confident this will work then let’s get this sucker merged.

Thanks everyone for tolerating my fixations.

@znmeb znmeb self-requested a review May 20, 2018 18:31
@znmeb
Copy link
Contributor

znmeb commented May 20, 2018

Ship it!!

@MikeTheCanuck MikeTheCanuck merged commit b3b7679 into staging May 21, 2018
@MikeTheCanuck MikeTheCanuck deleted the variable-refactor branch May 21, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants