Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new integration [djansen1987/SAJeSolar] #1042

Merged
merged 5 commits into from
Aug 27, 2021
Merged

Conversation

djansen1987
Copy link
Contributor

Please add my custom component for the SAJ eSolar Platform

Please add my custom component for the SAJ eSolar Platform
@hacs-bot hacs-bot bot changed the title Add integration Adds new integration [djansen1987/SAJeSolar] Aug 8, 2021
@hacs-bot
Copy link

hacs-bot bot commented Aug 8, 2021

Running checks on djansen1987/SAJeSolar

tommerkestijn
tommerkestijn previously approved these changes Aug 9, 2021
LowKey88
LowKey88 previously approved these changes Aug 9, 2021
Copy link

@LowKey88 LowKey88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working.

Copy link
Contributor

@aex351 aex351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your integration contains a manifest.json, however some minimum requirements seem to be missing:
https://developers.home-assistant.io/docs/creating_integration_manifest/

Also have a look at 'Github Actions' for both HACS and HA. This will allow you to verify such points automatically.

jbouwh
jbouwh previously approved these changes Aug 9, 2021
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@djansen1987
Copy link
Contributor Author

Your integration contains a manifest.json, however some minimum requirements seem to be missing:
https://developers.home-assistant.io/docs/creating_integration_manifest/

Also have a look at 'Github Actions' for both HACS and HA. This will allow you to verify such points automatically.

Thanks, your correct, i forgot 2 items. I am a bit new to github and do not understand the action part that good. Is it really necessary or is it for pre-validation?

@djansen1987
Copy link
Contributor Author

/recheck

@hacs-bot hacs-bot bot added recheck and removed recheck labels Aug 10, 2021
aex351
aex351 previously approved these changes Aug 13, 2021
@aex351
Copy link
Contributor

aex351 commented Aug 13, 2021

@djansen1987, approved your PR. Great to see you have implemented the changes. It makes your integration compliant.

To continue your question/remark you mentioned in my pull request about this one. I don't think your pull request is stuck because of my previous change request. You will need reviewers with write access. I don't have that and I only know one person who does, the owner of this repository @ludeeus. So you will need to wait for him to approve your pull request.

@ludeeus ludeeus marked this pull request as draft August 15, 2021 19:07
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djansen1987 djansen1987 marked this pull request as ready for review August 25, 2021 07:48
@djansen1987
Copy link
Contributor Author

CI does not pass
https://hacs.xyz/docs/publish/include/#before-submitting

Hi @ludeeus , i have fixed the branding and it should be good to go.

@ludeeus ludeeus merged commit 862aeb6 into hacs:master Aug 27, 2021
@hacs-bot
Copy link

hacs-bot bot commented Aug 27, 2021

Your repository is now added to HACS 🎉

Here is a few resources that can be useful:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants