-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new integration [djansen1987/SAJeSolar] #1042
Conversation
Please add my custom component for the SAJ eSolar Platform
Running checks on djansen1987/SAJeSolar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your integration contains a manifest.json, however some minimum requirements seem to be missing:
https://developers.home-assistant.io/docs/creating_integration_manifest/
Also have a look at 'Github Actions' for both HACS and HA. This will allow you to verify such points automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks, your correct, i forgot 2 items. I am a bit new to github and do not understand the action part that good. Is it really necessary or is it for pre-validation? |
/recheck |
@djansen1987, approved your PR. Great to see you have implemented the changes. It makes your integration compliant. To continue your question/remark you mentioned in my pull request about this one. I don't think your pull request is stuck because of my previous change request. You will need reviewers with |
58ab85a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI does not pass
https://hacs.xyz/docs/publish/include/#before-submitting
Hi @ludeeus , i have fixed the branding and it should be good to go. |
Your repository is now added to HACS 🎉 Here is a few resources that can be useful:
|
Please add my custom component for the SAJ eSolar Platform