-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exporter/traits): parent bounds on impl and associated types #532
Conversation
3d63899
to
148791f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
- I'm not annotating all changes, but please add comments to all code you touch that doesn't have comments yet.
- Comments/messages like "make more ergonomic" or "update x" are not useful. What is the change doing?
- There seem to be some renamings in here. Please split out mass changes like this in future.
Thanks for the review! I added some documentation. For Yeah, such vague commit messages aren't great. though, here by |
This commit adapts the engine to recent changes in the exporter. It also changes the following in the AST: - renames `trait_ref` into `trait_goal`; - introduces `Ast.impl_ident`; - add `impl_ident`s in various places.
4b6023c
to
724372b
Compare
This PR:
clause_id
s;trait_ref
AST type intotrait_goal
;impl_ident
in the AST;In a more high-level view, this PR adds the things missing in the exporter for fully supporting explicit implementation expressions.
I think now we have all the information in hax' AST to extract code with already resolved traits. For instance, we should be able to rework the F* backend so that we don't rely on TC inference on F* side any longer.