-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the logging system #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomcteixeira
added
the
enhancement
Enhancing an existing feature of adding a new one
label
Nov 4, 2021
amjjbonvin
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me - the logic makes sense.
But git report conflicts that need to be resolved manually
Yes, now gives the expected output (not file size), running with
|
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing in a different way after comments in #97
Updates and cleans the logging system.
stdout
. Before it was saved tostderr
because of the default value of StreamHandler. This is noted mostly when running SBATCHerror
messages as saved also tostderr
log
inside the run folder.I needed to do a quick trick to keep the logging in stdout and in the
log
file to accommodate the first steps during the configuration reading. Basically, messages are reported tostdout
and to aStringIO
until thelog
file is defined. After that, the buffer in StringIO is saved to the log file, and the logging continues normally after that. Seeclis/cli.py
.This PR does not clean the logging messages per se, nor does it adds progression bars as discussed in #97. Instead, this PR just updates the logging system itself. These other functionalities will be built on top of this and will be submitted in other PRs.