Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run examples scripts #238

Merged
merged 7 commits into from
Jan 4, 2022
Merged

add run examples scripts #238

merged 7 commits into from
Jan 4, 2022

Conversation

joaomcteixeira
Copy link
Member

Add script to run examples in a row. Why not have this here for now? ☺️

Usage (from within the examples/ folder):

./run_examples.sh 0  # -> runs all examples regardless of errors
./run_examples.sh 1  # -> run all examples but will stop if an error happens

@joaomcteixeira joaomcteixeira added the feature New feature request label Dec 30, 2021
@joaomcteixeira joaomcteixeira added this to In Progress in Features via automation Dec 30, 2021
@joaomcteixeira joaomcteixeira self-assigned this Dec 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #238 (0831a15) into main (18afb31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files          48       48           
  Lines        3052     3052           
=======================================
  Hits         1652     1652           
  Misses       1400     1400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18afb31...0831a15. Read the comment docs.

Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could take 0 as default in case of no argument given...

Also adds some more info messages
examples/run_examples.sh Outdated Show resolved Hide resolved
@joaomcteixeira
Copy link
Member Author

@amjjbonvin made it in python at the end.

python run_examples.py -h

you need to have the haddock3 environment activated. But that also happened with the previous sh version. Any new examples must be added to the pipe manually by editing the script. I did not make an official CLI out of this because it only makes sense to run it inside examples/ and because of the hardcoded examples (it should be this way).

@joaomcteixeira joaomcteixeira merged commit 609e23d into main Jan 4, 2022
Features automation moved this from In Progress to Done Jan 4, 2022
@joaomcteixeira joaomcteixeira deleted the run_examples branch January 4, 2022 12:19
@rvhonorato
Copy link
Member

Python 1 x Bash 0! 😉

@amjjbonvin
Copy link
Member

amjjbonvin commented Jan 4, 2022 via email

@joaomcteixeira
Copy link
Member Author

🤣 i needed to add more chars because of the -h option 😝 definitively I wrote the python version better.

@joaomcteixeira joaomcteixeira added the CI / repository Continuous integration or repository organization label Jan 5, 2022
@amjjbonvin amjjbonvin linked an issue Jan 25, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI / repository Continuous integration or repository organization feature New feature request
Projects
Features
  
Done
Development

Successfully merging this pull request may close these issues.

Improve examples
4 participants