-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor scoring pipeline #38
Conversation
src/haddock/setup.py
Outdated
begin_mol = (begin_dir / f'{mol_identifier}.pdb').absolute() | ||
shutil.copy(input_mol, begin_mol) | ||
|
||
input_params['molecules'][mol_identifier] = begin_mol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you keep the link between the new begin_mol
and the original mol_identifier
path that is now in data_dir
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't, the data is there just for safekeeping the pre-processed inputs, it's how its done in production (2.4)
Adding my suggestions at: https://github.com/rvhonorato/haddock3/pull/1 |
Following: #39 I added a simplified scoring toml so that the run executes.
Avoids having lots of files under the main `haddock` source folder.
Okay. I think I finished reviewing your PR; my reviews and suggestions at: https://github.com/rvhonorato/haddock3/pull/1, if you accept them they will become part of this PR automatically. It is a great idea @rvhonorato to firstly check the configuration file and prepare the files and folders for run. I like that idea. My suggestions in your branch are basically pythonic and architecture refactoring. I dislike the OOP-everywhere paradigm. It might be worthwhile in other languages but in python not really. It is useful where it is useful, but creates a lot of headaches otherwise. I haven't implemented any tests, but you'll see tests are easy to write with the changes I propose. You'll notice the new folder Let me know, |
Studying and suggesting on `scoring_refactor`
Thanks for the review and the edits @joaomcteixeira ! |
This PR is a small refactoring to the scoring pipeline that implements #37 and adds a Setup python module, in which we should centralize the validations related to the .toml file.
I also re-introduced the haddock-style
begin/
anddata/
directories.