Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomisation of starting orientations at flexref #729

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

amjjbonvin
Copy link
Member

@amjjbonvin amjjbonvin commented Oct 20, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Add option to randomise starting orientations at the flexref stage to allow for docking during flexible refinement.
An example is provided for protein-glycans

Implementation for issue #722

@amjjbonvin amjjbonvin added feature New feature request CNS Improvements in the CNS engine m|flexref flexref module labels Oct 20, 2023
@amjjbonvin amjjbonvin added this to In progress in Enhancements via automation Oct 20, 2023
@amjjbonvin amjjbonvin added this to In progress in CNS via automation Oct 20, 2023
@amjjbonvin amjjbonvin self-assigned this Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e2dff1) 75.48% compared to head (6f2c916) 75.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   75.48%   75.48%           
=======================================
  Files         115      115           
  Lines        8204     8204           
=======================================
  Hits         6193     6193           
  Misses       2011     2011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvhonorato rvhonorato linked an issue Oct 20, 2023 that may be closed by this pull request
@amjjbonvin amjjbonvin merged commit 71f8921 into main Oct 20, 2023
6 checks passed
Enhancements automation moved this from In progress to Done Oct 20, 2023
CNS automation moved this from In progress to Done Oct 20, 2023
@amjjbonvin amjjbonvin deleted the randorient branch October 20, 2023 07:24
@mgiulini
Copy link
Contributor

isn't it missing the example with the glycans?

@amjjbonvin
Copy link
Member Author

Indeed - forgot to add those files. Fixed now

@rvhonorato rvhonorato changed the title Randomisation of starting orientations at flexref - issue #722 Randomisation of starting orientations at flexref Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CNS Improvements in the CNS engine feature New feature request m|flexref flexref module
Projects
CNS
  
Done
Enhancements
  
Done
Development

Successfully merging this pull request may close these issues.

Add option for randomising initial structures in the flexref module
3 participants