Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modif float comparisons in contact map tests #764

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Dec 21, 2023

Solve the digit comparison issues while changing hardware by using np.isclose()

@VGPReys VGPReys added the enhancement Enhancing an existing feature of adding a new one label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8a63d9) 72.54% compared to head (00c8ac4) 72.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files          80       80           
  Lines        7566     7566           
=======================================
  Hits         5489     5489           
  Misses       2077     2077           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust you on the number of digits 🚀

@VGPReys VGPReys merged commit 18a5528 into main Dec 21, 2023
6 checks passed
@VGPReys VGPReys deleted the contmap-testdigits branch December 21, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one m|contactmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants