Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizes cli.py #85

Merged
merged 7 commits into from
Sep 6, 2021
Merged

Modularizes cli.py #85

merged 7 commits into from
Sep 6, 2021

Conversation

joaomcteixeira
Copy link
Member

  • modularizes cli.py by decoupling the main from the argparse and by adding additional intermediate functions to allow control flow at any point in future. I link to program on demand but these functions are minimal and provide a great deal of modularity.
  • abstracts some other functions related to CLI arguments
  • adds tests

This PR gently assumes #84 will be accepted ⚠️ do not merge here if #84 is rejected. ⚠️

@joaomcteixeira joaomcteixeira added the enhancement Enhancing an existing feature of adding a new one label Sep 3, 2021
@joaomcteixeira joaomcteixeira self-assigned this Sep 3, 2021
@joaomcteixeira joaomcteixeira added this to In progress in Enhancements via automation Sep 3, 2021
@joaomcteixeira
Copy link
Member Author

Merging this PR. Please note you need to repeat python setup.py develop --no-deps in your haddock3 env after synchronizing the main.

@joaomcteixeira joaomcteixeira merged commit 0f1cb4c into haddocking:main Sep 6, 2021
Enhancements automation moved this from In progress to Done Sep 6, 2021
@joaomcteixeira joaomcteixeira deleted the cliup branch September 6, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one
Projects
Enhancements
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants