This repository has been archived by the owner on Jul 23, 2020. It is now read-only.
Fix orientation threshold #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was the wrong way around
The old code gave a priority to portrait orientation, so that if rotation reached the portrait threshold, it switched straight away. This is problematic if the device you're dealing with isn't a mostly portrait phone, but a tablet that can be used in both orientations equally. Landscape thresholds and portrait thresholds can (and they do) overlap. In the overlapping area we should try to keep the previous orientation until that threshold has passed. [Bastien Nocera: Added test change]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.