ENH: Add support for composite ROIs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! Looks like you need to rebase. |
Closed
|
Ah, I was expecting this. Will rebase onto master now. |
scottclowe
force-pushed
the
enh_composite-rois
branch
from
0628532
to
dcbb08c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I based this on these sources:
The composite type used to be returned a rectangle containing only the bounding box around the composite ROI. We still return this bounding box data, but now also the paths contained within the composite ROI. The
'paths'field of the composite ROI contains a list of paths describing the ROI. Each path is made up of a series of nodes, encoded as a pair of values in a tuple. We support the ability to decode PathIterator segments which are quadratic or cubic, but it doesn't appear that ImageJ ever saves such paths (it appears to be impossible to save a composite ROIs with sub-pixel resolution and hence paths are always linear).Closes #9.