Support parsing year only dates #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also make I think it also needs some documentation somewhere explaining that missing month and day will be set to 1, and missing hour, minute, and second will be set to 0. |
| @@ -81,6 +81,10 @@ test_that("ISO8601 partial dates are not parsed", { | |||
| expect_equal(n_problems(parse_datetime("2001-01")), 1) | |||
| }) | |||
|
|
|||
| test_that("Year only gets parsed", { | |||
| expect_equal(parse_datetime("2010", "%Y"), r_parse("2010-01-01", "%Y-%m-%d")) | |||
There was a problem hiding this comment.
Maybe better to compare to ISODate(2010, 01, 01)?
|
OK I have updated the PR. Related: currently parse_date('10-10', '%m-%d')We should probably either default to |
|
Yeah, that should be an error. Want to tackle it while you're in there? |
|
OK done (in this same pr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing a year-only e.g.
%Yformat:It's a bit of an edge case, but if the user specifically sets the format to
%Ythis should work.