Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameter order in getRelativeURL for form submission/added submit_form_valiues #61

Closed
wants to merge 5 commits into from

Conversation

MrFlick
Copy link

@MrFlick MrFlick commented Jan 10, 2015

The base URL from session$url should be the second parameter to XML::getRelativeURL

@MrFlick MrFlick mentioned this pull request Jan 10, 2015
@MrFlick
Copy link
Author

MrFlick commented Jan 11, 2015

Added in a submit_form_values function per issue #2.

@MrFlick MrFlick changed the title Fixed parameter order in getRelativeURL for form submission Fixed parameter order in getRelativeURL for form submission/added submit_form_valiues Jan 11, 2015
@hadley
Copy link
Member

hadley commented Apr 15, 2015

Could you please do a new pull request just with the submit_form_values function?

@hadley hadley closed this Apr 15, 2015
@MrFlick
Copy link
Author

MrFlick commented Apr 17, 2015

OK. I just tried to submit just that patch as a new pull request. Let me know if i misinterpreted your request. Note that I didn't make any attempt to export the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants