changed the testthat_results data frame column "skipped" from numeric… #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? Couldn't there be multiple skipped tests? |
|
unless mistaken, there's a row per test, and a test can only be skipped once. |
|
What do you mean by "multiple skipped tests" ? I thought that a skip() call ended the current test execution, like a return(). |
|
seems like the travis check failed because of the coverage. The R CMD check was successful... |
hadley
added a commit
that referenced
this pull request
Sep 24, 2015
changed the testthat_results data frame column "skipped" from numeric…
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to logical