Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply exit code to hadolint.sh #50

Merged
merged 1 commit into from Mar 24, 2022

Conversation

paulbarton90
Copy link
Contributor

Exiting with an exit code of 1 marks the job in github actions as a fail properly. This should help to fix #48. I have noticed that you need to explicitly add docker.io to the trusted registries when running the github action. I updated the testing action to run with the following configuration:

steps:
  - uses: actions/checkout@v2 
  - uses: hadolint/hadolint-action@v1.6.0
    with:
      dockerfile: Dockerfile
      trusted-registries: "docker.io"

@lorenzo
Copy link
Member

lorenzo commented Mar 24, 2022

thanks!

@lorenzo lorenzo merged commit 2bcb99c into hadolint:master Mar 24, 2022
@paulbarton90 paulbarton90 deleted the check_exit_status branch March 24, 2022 16:02
@offa
Copy link
Contributor

offa commented Mar 24, 2022

Thank you!

@paulbarton90
Copy link
Contributor Author

No problem. I believe the "trusted-registries" part is also fixed so is not longer required when running in the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reported issues wont fail the build
3 participants