Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to generate exec form (instead of shell form)? #22

Closed
ad-si opened this issue Feb 26, 2018 · 4 comments
Closed

How to generate exec form (instead of shell form)? #22

ad-si opened this issue Feb 26, 2018 · 4 comments

Comments

@ad-si
Copy link

ad-si commented Feb 26, 2018

https://docs.docker.com/engine/reference/builder/#entrypoint

ENTRYPOINT ["yarn", "start", "--"] vs ENTRYPOINT yarn start --

How can I generate the exec form?

@ad-si ad-si changed the title Exec form vs Shell form How to generate exec form (instead of shell form)? Feb 26, 2018
@ad-si
Copy link
Author

ad-si commented Feb 26, 2018

Well, entrypoint "[\"yarn\", \"start\", \"--\"]" seems to work. But it's awful 😅

@ad-si
Copy link
Author

ad-si commented Feb 26, 2018

entrypoint $ show ["yarn", "start", "--"] works too, but it's an awful hack 😂

@lorenzo
Copy link
Member

lorenzo commented Feb 26, 2018

@ad-si I agree. That function was not very well thought out when originally created. Your second hack is the cleanest one with now. I'll change that up too along with the changes for copy

@ad-si
Copy link
Author

ad-si commented Feb 26, 2018

For future reference: With language extensions it must be used like this:

{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE OverloadedLists #-}

entrypoint $ show (["yarn", "start", "--"] :: [String])

lorenzo added a commit that referenced this issue Mar 11, 2018
This is a breaking change, but improves the usability of copy and entrypoint
functions. Also adds the possibility to specify a from stage and permissions
for the copy argument

closes #21 and #22
@lorenzo lorenzo closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants