Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glsl::syntax::StructSpecifier::fields should use NonEmpty instead of Vec #24

Open
hadronized opened this issue Aug 30, 2017 · 3 comments
Open

glsl::syntax::StructSpecifier::fields should use NonEmpty instead of Vec #24

hadronized opened this issue Aug 30, 2017 · 3 comments
Labels
easy

Comments

@hadronized
Copy link
Owner

No description provided.

@LuisAyuso
Copy link

LuisAyuso commented Oct 14, 2017 •
edited
Loading

Hi, I would like to help with this project. Can you explain this issue a little more?
I mean, How does this improve code? NonEmpty is just an alias to vec? is it enforcing the constraint somehow that I can not see?

@hadronized
Copy link
Owner Author

Currently, it’s just an alias, yes. It’s not perfect – as in Haskell’s data NonEmpty a = a :| [a], but it’s something. I’ll edit the issue to make it clear what is needed. ;)

@LuisAyuso LuisAyuso mentioned this issue Oct 14, 2017
Closed
@LuisAyuso
Copy link

#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadronized @LuisAyuso