glsl::syntax::StructSpecifier::fields should use NonEmpty instead of Vec #24 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply clippy lints use condition in DoWhile # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch master # Your branch is up-to-date with 'origin/master'. # # Changes to be committed: # modified: src/parser.rs # modified: src/syntax.rs # modified: src/writer/glsl.rs # # Untracked files: # .DS_Store #
|
Thanks for taking the time to contribute! However, I’d like to keep the history clean, especially what a commit introduces. Can you split that in several commits? Also, I’m not a huge fan of annotating code with clippy things… |
|
Hello, Are you still up to maintaining that portion of code? It’s been some months now and I shall close this if you can’t work on it. The change is trivial and I might do it later (since an issue is open about that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glsl::syntax::StructSpecifier::fields should use NonEmpty instead of Vec #24
apply clippy lints
use condition in DoWhile