Change int to decimal to support more sensors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I will double check that this works with my IKEA sensor and merge after. |
|
I haven't noticed that the IKEA sensor doesn't even support decimal points, that's kind of bad. I think using |
hagronnestad
reviewed
Mar 2, 2024
| @@ -6,7 +6,7 @@ namespace Dirigera.Models | |||
| { | |||
| public class EnvironmentSensor : Device | |||
| { | |||
| public int CurrentTemperature { get; internal set; } | |||
| public decimal CurrentTemperature { get; internal set; } | |||
There was a problem hiding this comment.
I think double is a more appropriate type to use.
hagronnestad
approved these changes
Mar 2, 2024
|
Thank you, a new version of the Nuget package has been released: https://www.nuget.org/packages/Dirigera.Lib/1.0.6 Here's the GitHub release: https://github.com/hagronnestad/dirigera/releases/tag/1.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a decimal instead of int should make it compatible with non Ikea sensors too, for example the Aqare Temperature and umidity Sensor T1