Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): auth token expiration check #214

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

3fd
Copy link
Member

@3fd 3fd commented Mar 2, 2023

Fixes auth token expiration check:

expires_in of auth token is in seconds but TokenSet.expired() compared it to Date.now() which is in milliseconds.
This resulted in a token refresh before most API requests

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

🦋 Changeset detected

Latest commit: 850f210

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hahnpro/hpc-api Patch
@hahnpro/flow-sdk Patch
flow-module-examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@timoklingenhoefer timoklingenhoefer merged commit 1b1b2d0 into main Mar 3, 2023
@timoklingenhoefer timoklingenhoefer deleted the fix/token-expiration branch March 3, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants