Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global-context): Adding a "global context" instead of interpolate #378

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

Rainer-Fink
Copy link
Contributor

@Rainer-Fink Rainer-Fink commented Sep 17, 2024

If the properties of the flow change, some of these are not adopted by the elements, which is why they should first be set in the elements by means of a “global context / a context manager” in the flow application at every update.

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: d008d8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hahnpro/flow-sdk Major
flow-module-examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

let newValue = value;
let m: RegExpExecArray;
do {
m = blockRegEx.exec(value);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '${' and with many repetitions of '${!'.
This
regular expression
that depends on
library input
may run slow on strings starting with '${' and with many repetitions of '${!'.
This
regular expression
that depends on
library input
may run slow on strings starting with '${' and with many repetitions of '${!'.
This
regular expression
that depends on
library input
may run slow on strings starting with '${' and with many repetitions of '${!'.
@Rainer-Fink Rainer-Fink marked this pull request as ready for review September 17, 2024 08:29
@Rainer-Fink Rainer-Fink marked this pull request as draft September 17, 2024 08:32
- test for the context manager and its purpose / usage
- properties object with the placeholder property-object in flow elements to be able to replace with new values at update
@Rainer-Fink Rainer-Fink marked this pull request as ready for review September 18, 2024 10:48
Copy link

sonarcloud bot commented Sep 20, 2024

@timoklingenhoefer timoklingenhoefer merged commit fc756c6 into main Sep 23, 2024
21 of 23 checks passed
@timoklingenhoefer timoklingenhoefer deleted the feat/global-context branch September 23, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants