Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: slice loop replace #502

Merged
merged 1 commit into from
Oct 12, 2023
Merged

chore: slice loop replace #502

merged 1 commit into from
Oct 12, 2023

Conversation

testwill
Copy link
Contributor

No description provided.

@testwill
chore: slice loop replace
0847a6c 
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
hahwul
hahwul approved these changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@hahwul hahwul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great! I believe it's better code.

@hahwul hahwul merged commit fa1274e into hahwul:main Oct 12, 2023
11 checks passed
@testwill testwill deleted the slice branch October 12, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahwul hahwul hahwul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testwill @hahwul