ExecutableAllocator: Fix the size of the executable pool to 32MB. #22
Conversation
The x86_64 default was 1GB, which winds up wasting a *huge* amount of (non-overcommitting) memory on Haiku. 32MB is the current default on 32-bit, so this is probably fine for everywhere.
|
I didn't merge this because I don't know if you want to put it in some other config header or something. But this makes Web+ usable again on x64 systems with not a lot of swap... |
|
Can we make it use overcommited memory? |
|
So, after digging a bit, this should really be uncommitted memory. I expect the large area is there for performance reasons (it's better to create a single area and do everything inside it). Eventually the allocation is done through Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp , reserveUncommitted, which has a special case on Linux to use mmap with the NORESERVE flag. It also attempts to use madvise but we provide only posix_madvise. So either we need to add NORESERVE to our mmpa implementation, or create an OSAllocatorHaiku that uses areas instead of mmap. Moreover, if we still want to change the size of this, we should do it in PlatformHaiku.cmake as it is done for the Playstation port which forces 64MB (possibly because they use FreeBSD and also don't have the overcommitting). Fixing this means we save 1GB on 64bit, but also at the same time save 32MB on 32bit, which is also welcome, I think? So we can brag about our low memory use everywhere? :) |
|
0c2fde4 supplants this. |
The x86_64 default was 1GB, which winds up wasting a huge
amount of (non-overcommitting) memory on Haiku. 32MB is the
current default on 32-bit, so this is probably fine for everywhere.