Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower MatrixEntriesTable #5799

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Lower MatrixEntriesTable #5799

merged 1 commit into from
Apr 5, 2019

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Apr 5, 2019

Fixes #5777

Timing in master for benchmark/matrix_table_entries_table:

run 1 took 91.15s
run 2 took 86.58s
run 3 took 85.45s
Mean, Median: 87.73s, 86.58s

Timing on this branch:

run 1 took 20.33s
run 2 took 20.98s
run 3 took 21.28s
Mean, Median: 20.86s, 20.98s

@tpoterba
Lower MatrixEntriesTable
9e9a73f 
Fixes hail-is#5777

Timing in master for benchmark/matrix_table_entries_table:

    run 1 took 91.15s
    run 2 took 86.58s
    run 3 took 85.45s
    Mean, Median: 87.73s, 86.58s

Timing on this branch:

    run 1 took 20.33s
    run 2 took 20.98s
    run 3 took 21.28s
    Mean, Median: 20.86s, 20.98s
danking
danking approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danking danking merged commit 2721a32 into hail-is:master Apr 5, 2019
@tpoterba tpoterba mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danking danking danking approved these changes

Assignees

@danking danking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpoterba @danking