Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to GH actions and pre-commit #172

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Migrate to GH actions and pre-commit #172

merged 5 commits into from
Mar 2, 2021

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented Mar 2, 2021 •
edited
Loading

Close #171

@malmans2
Copy link
Contributor Author

malmans2 commented Mar 2, 2021

All set. We're also building readthedocs at each PR to check the docs. Is not showing up in the checks though, so I have to figure it out. Must be a permission issue.

@malmans2
Copy link
Contributor Author

malmans2 commented Mar 2, 2021

@ThomasHaine you should get an email from readthedocs

ThomasHaine
ThomasHaine approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. I've approved the readthedocs access request.

@malmans2
Copy link
Contributor Author

malmans2 commented Mar 2, 2021

Merging!

@malmans2 malmans2 merged commit 3cf9f39 into master Mar 2, 2021
@malmans2 malmans2 deleted the actions branch March 2, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaine ThomasHaine ThomasHaine approved these changes

@asiddi24 asiddi24 Awaiting requested review from asiddi24

@Mikejmnez Mikejmnez Awaiting requested review from Mikejmnez

@renskegelderloos renskegelderloos Awaiting requested review from renskegelderloos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CI
2 participants
@malmans2 @ThomasHaine