Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin xarray for now #245

Merged
merged 1 commit into from
Jul 25, 2022
Merged

pin xarray for now #245

merged 1 commit into from
Jul 25, 2022

Conversation

Mikejmnez
Copy link
Collaborator

We are going to also pin (for now) xarray < 2022.6. There was a new release last week, with lost of internal changes (based on refactoring), and testing on sciserver this xr version cause an error that with maskH.where(drop=True) on the before performing the cutout. The test image on sciserver that Mitya installed has the previous version of xarray (xarray 2022.3), which does not produce the error...

I need to spend some time on this. Again, it may be very small, but likely very sublte. For now will I'll have to pin xarray

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #245 (803a925) into main (647e07a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          10       10           
  Lines        3634     3634           
  Branches      773      773           
=======================================
  Hits         3474     3474           
  Misses        109      109           
  Partials       51       51           
Flag Coverage Δ
unittests 95.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Mikejmnez Mikejmnez merged commit e9a6f42 into hainegroup:main Jul 25, 2022
@Mikejmnez Mikejmnez deleted the iss243 branch July 25, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant