Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to cutout bug #257

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Quick fix to cutout bug #257

merged 1 commit into from
Sep 2, 2022

Conversation

Mikejmnez
Copy link
Collaborator

This is a minimal, quick fix to the bug described in #256. I am not including any new testing, as a more comprehensive testing and documentation needs to be included and will take a bit longer time.

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #257 (460ea34) into main (c345fd7) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   95.59%   95.54%   -0.06%     
==========================================
  Files          10       10              
  Lines        3634     3634              
  Branches      773      773              
==========================================
- Hits         3474     3472       -2     
- Misses        109      110       +1     
- Partials       51       52       +1     
Flag Coverage Δ
unittests 95.54% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/subsample.py 97.99% <100.00%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@renskegelderloos
Copy link
Collaborator

@ThomasHaine can you please add the group to authorized users to merge the main branch?

@Mikejmnez Mikejmnez merged commit 8eb26c9 into hainegroup:main Sep 2, 2022
@Mikejmnez Mikejmnez deleted the iss256 branch September 2, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants