Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid corrections in intake file for ECCO and LLC4320 #261

Merged
merged 7 commits into from
Sep 13, 2022

Conversation

asiddi24
Copy link
Collaborator

Addressed #255 and updated the grid coords defined for ECCOv4r4 and LLC4320. Now the grid looks correct.

od.grid

<xgcm.Grid>
Z Axis (not periodic, boundary=None):
  * center   Z --> left
  * left     Zl --> center
  * outer    Zp1 --> center
  * right    Zu --> center
X Axis (not periodic, boundary=None):
  * center   X --> right
  * right    Xp1 --> center
time Axis (not periodic, boundary=None):
  * center   time_midp --> outer
  * outer    time --> center
Y Axis (not periodic, boundary=None):
  * center   Y --> right
  * right    Yp1 --> center

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #261 (ed2f754) into main (1e2f203) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files          10       10           
  Lines        3634     3634           
  Branches      773      773           
=======================================
  Hits         3472     3472           
  Misses        110      110           
  Partials       52       52           
Flag Coverage Δ
unittests 95.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ThomasHaine ThomasHaine merged commit 647553e into hainegroup:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants