Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oceandataset dictionary style access #262

Merged
merged 23 commits into from
Sep 26, 2022
Merged

oceandataset dictionary style access #262

merged 23 commits into from
Sep 26, 2022

Conversation

MaceKuailv
Copy link
Collaborator

you can do od['salt'] now

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #262 (b2c47b9) into main (647553e) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   95.54%   95.51%   -0.03%     
==========================================
  Files          10       10              
  Lines        3634     3636       +2     
  Branches      773      773              
==========================================
+ Hits         3472     3473       +1     
- Misses        110      111       +1     
  Partials       52       52              
Flag Coverage Δ
unittests 95.51% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/_oceandataset.py 97.36% <50.00%> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MaceKuailv
Copy link
Collaborator Author

@Mikejmnez The output of
>>> od[['S','U']]
is this:

<xarray.Dataset>
Dimensions:  (time: 4, Z: 55, Y: 154, X: 207, Xp1: 208)
Coordinates:
  * Z        (Z) float64 -1.0 -3.5 -7.0 -11.5 ... -681.5 -696.5 -711.5 -726.5
  * X        (X) float64 -22.02 -21.98 -21.93 -21.89 ... -13.05 -13.01 -12.96

It works like we intended

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ThomasHaine ThomasHaine merged commit 51d1cc5 into hainegroup:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants